Ref: $CASE/bdelog2ks/maushah/docs/myFinalReport Rev: $CASE/bdelog2ks/FinalRpt_maushah.txt Software Engineering I (91.523) Spring 2000 Submitted by: Maulik Shah (maushah) Revised (using fmt to word-wrap parags) by RJL 2k0522. TBD: Checked-in status TBconfirmed - assume checked in - RJL Ref: $CASE/bdelog2ks/maushah/genv11_0502/bde/src/leftmenu_cb.cc Log Report: $Log: leftmenu_cb.cc,v $ Revision 1.6.2.3 2000/05/18 00:57:14 maushah In GENv10.2, the left menu bar on BDE showed the default node shape as Circle while the default node shape was Rectangle. That needed to change the default button set (a parameter which specifies what initial button value is set to) to 1 (default shape=Rectangle) from 0 (default shape=Circle). The fix is implemented in GENv11. <<<< RJL: BDE/src should not depend on GENv# - ??? Ref: $CASE/bdelog2ks/maushah/genv11_0502/bde/src/*.cc Removal of unwanted GENv6 condition loops. I refracted the code by removal of GENv6 conditional loops, which were no longer in effect since we ran GENv11. Ref: $CASE/bdelog2ks/maushah/genv11_0502/bde/src/*.cc Changed #if 0 to #ifdef 0 since the previous part got me into trouble with xmkmf -a (imake). After the change to #ifdef 0, xmkmf did not fail since xmkmf runs the makefiles in ~/bde2alpha_rv/ and make runs genv11 to make pr_util. Thus to maintain code consistency, I modified #if 0 to #ifdef 0. Ref:$CASE/bdelog2ks /NEW_VERSION_bugs_ms.2k0413 NEW_VERSION is used when BUILDING chgen; when chgen runs it controls whether CODE to check on View name (subschema tables) and table version #s is GENERATED in pr_*.c. (These are not in CVS - only the Imakefile is.) pr_init precedes pr_load. pr-init parses a list of local *.dat files and scans these files to verify that the specified version numbers by the Views to be used did not contain overlapping pkeys; pr_init also finds the largest pkey in use for each VERSION of each table in the View. pr_add assigns consecutive pkeys after that. The version number part of this approach was abandoned because it is incompatible with future cvs version management of bde *.dat files. But -DNEW_VERSION disabled View as well as version checks. Right now, in bde, pr_init (or pr_load) only scans the single opened file and pkeys are only unique within that file. (Merging files with the same tables but concatenation is only possible after translating pkeys of one file so they don't conflict with the other.) The View part (selecting subgraphs of the ERD) is important to selectively filter relevant tables e.g. for input and output Views during schema converters like bde2htm, bde2sch, and bde2STD and ....For now, it is disabled in bde as not relevant during diagram editing. I inspected gen_pr_add and found this comment re: NEW_VERSION that also bypasses the version test: -------- gen_pr-add.c line 19: inserted NEWVERSION flag for 0 version problem -CEM 19/11/92- gen_pr_add line 170: #ifndef NEW_VERSION fprintf(prload_fp, "\ if (hcg_view_list.view_list[hcg_view_idx].version_list[hcg_tbl_idx] == ' \\0')\n\ return;\n\"); #endif My conclusion is that (barring any other context that reverses the effect of NEW_VERSION definition) we only need to add -DNEW_VERSION to the chgen run command in pr_util/Imakefile to bypass this undesired test. (When genv11 runs, it also needs NEW_VERSION defined, as it is an application of pr_util from the metaschema. The Makefile to build gen11 already does this). I did a cvs diff -r bde2alpha_rv first, then cvs update; (if I don't already have sticky bde/CVS/Tag = bde2alpha_rv then I need to cvs update -b bde2alpha_rv bde first. That will make the tag stick to my directory (confirm to check that bde/CVS/Tag = bde2alpha_rv). Meanwhile, cvs co -r bde2alpha_rv $BDEROOT works to checked out and build bde and add sticky tag bde2alpha_rv in your workspace. Note: I haven't yet added comments about caption_fit_to_text in my report yet, since the bug is just reported and not yet fixed. The effects would reflect code changes in three files: $CASE/bdelog2ks/maushah/genv11_0502/bde/src/captionops.cc $CASE/bdelog2ks/maushah/genv11_0502/bde/src/textops.cc $CASE/bdelog2ks/maushah/genv11_0502/bde/src/text.cc Nodes and Captions are not the same. Node text is in HN--->HA lines and Caption text is in CG--->GX lines. Captions and Nodes ARE both resizable - from center outward, which is hard to control, because text does NOT stick to upper left corner but to center during resize.