To: P Mittra From: lechner Subj: Info on bde2java source files which fixed bugs and added bde2gif RJLRef: /usr/proj3/case/97s523/bde2gif/hren/hren.vs.gzebDiffs.hlp HRen's report (and other files there) describe her enhancements ($CASE/97s523/bde2gif/hren/bdejava) to gzeballos' java sources GZeballo's team extended the original bde2java from mfernandes and drosato ($CASE/96s523/bde2jav1/base/java) with standard web-browsable javadoc comments. It may have fixed a few bugs also. I suspect hren did not update the javadoc comments or update the cvs repository version, if any. HRen points out that the newer VC++ project of jvinarub/acowles ($CASE/96f523/bde2vjpp/jvinarub) is much less functional than mfernandes' earlier project. I recommend you read hren's report.* and other text files there for hints on coding style problems and bug fix status. Your bug fixes should really start with hren's version. See also $CASE/96f523/bde2java/avedula/bdelink/aareadme; avedula's task was to fix the link HL maintenance, and there are two bdeLink.java files in his path. AVedula, zwang and wau directories all have slightly differnt java source versions than lechner's which I compared to hren's. HRen's java code differs from gzeballo's by only about 350 diff lines, whereas it differs from mfernand's ($CASE/96s523/bde2jav1/base/java) and jvinarub's ($CASE/96f523/bde2vjpp/jvinarub) by 5K and 10K lines respectively. I ran several diff experiments to make the above conclusions by a somewhat tortuous path. Below are some useful awk filters and info on chanes. Bob Lechner ========================================================= The jvinarub version of bde2java for vj++ (bde2vjpp) differs from hren's by 10K diff lines; mfernand's version differs by about 5K lines. These diffs show that hren added at most 3.5K new SLOC (^<) and removed at most 1K SLOC (^>) relative to mfernand's 96s523/bde2jav1 version (replacememnts appear in both counts): ------------- (wd now: /usr/proj3/case/97s523/bde2gif/hren/bdejava) jupiter.cs.uml.edu(252)> diff . $CASE/96s523/bde2jav1/base/java | wc 5231 18443 148969 jupiter.cs.uml.edu(255)> diff . $CASE/96s523/bde2jav1/base/java | grep '^>' | wc 1029 3012 37576 jupiter.cs.uml.edu(256)> diff . $CASE/96s523/bde2jav1/base/java | grep '^<' | wc 3480 14502 123648 jupiter.cs.uml.edu(257)> diff . $CASE/96s523/bde2jav1/base/java | grep '^diff' | wc 24 96 2271 ------------- HRen's version of bde2java differs from jvinarub's version for vj++ in $CASE/96f523/bde2vjpp/jvinarub/code/source by twice as much as it differs from mfernand's version: HRen's hren/hren_jvinarub.dif file is slightly out of datei: There is a new diff | wc below. --------------- /usr/proj3/case/97s523/bde2gif/hren/bdejava jupiter.cs.uml.edu(295)> diff . /usr/proj3/case/96f523/bde2vjpp/jvinarub/code/so urce|wc 10082 24636 186020 jupiter.cs.uml.edu(296)> wc ../*.dif 10087 24619 185780 ../hren_jvinarub.dif ------------- HRen made two major additions to bde2java (see her report). She added outputGif to class bdeAppletFrame.java; She also modified method fprint in bdeGraph.java. Since there are many other diffs, I suspected and then verified that she actually started with the successor to mfernand's code, $CASE/96f523/bde2java/gzeballo GZeballos' team of 4 added javadoc comments. I was interested in how/why hren made so many changes to mfernand's sources; below is a filter and its printout of the start line and number of lines for each diff that is saved in hren's .dif file: ---------- jupiter.cs.uml.edu(326)> grep ^diff *.dif | awk '{print $1 $3}' | awk -F: '{prin t $1," ", $2}' | awk '{print save, " ", $1-save, " ", file; save = $1; file = $2 }' 12 12 78 diff./GraphBox.java 90 163 diff./InfoDialog.java 253 334 diff./MultiLineLabel.java 587 1518 diff./bde2JavaApplet.java 2105 109 diff./bdeAboutBox.java 2214 1708 diff./bdeAppletFrame.java 3922 260 diff./bdeBendPoint.java 4182 294 diff./bdeCaptionText.java 4476 2151 diff./bdeGraph.java 6627 90 diff./bdeGraphBox.java 6717 329 diff./bdeGraphCaption.java 7046 77 diff./bdeGraphSelectionBox.java 7123 92 diff./bdeJava.java 7215 983 diff./bdeLink.java 8198 200 diff./bdeLinkCaption.java 8398 39 diff./bdeMenuItem.java 8437 572 diff./bdeNode.java 9009 157 diff./bdeNodeAttribute.java 9166 99 diff./bdeNodeAttributesBox.java 9265 158 diff./bdeReference.java 9423 338 diff./bdeText.java 9761 104 diff./bdeToolBox.java 9865 107 diff./menuList.java 9972 62 diff./menubox.java jupiter.cs.uml.edu(327)> --------------- There are many other diffs; I grepped for the
keyword
to see if she started with gzeballo's successor which added
javadoc comments to mfernand's code This was inded a major source
of diffs:
------------
jupiter.cs.uml.edu(343)> grep '^<.*' *.dif | wc
345 1032 5951
jupiter.cs.uml.edu(344)> grep '^>.*' *.dif | wc
0 0 0
---------------
Thereore I re-ran the diff beteen hren's and gzeballo's paths:
(the gzeballo path is realy to gzeballo/../lechner,
since there wer four copies of the java path under that team,
none of them gzeballo's).
-------------
jupiter.cs.uml.edu(457)> wc *.dif
356 1272 11900 hren.vs.gzeballo.dif
10087 24619 185780 hren_jvinarub.dif
--------------
Only 7 files differ now; 2/3 of the diffs are in bdeAppletFrame/java:
-------
jupiter.cs.uml.edu(461)> grep ^diff hren.vs.gzeballo.dif|awk '{print $1 $3}'
34:diff./bde2JavaApplet.java
40:diff./bdeAppletFrame.java
273:diff./bdeGraph.java
309:diff./bdeGraphBox.java
314:diff./bdeGraphCaption.java
328:diff./bdeJava.java
341:diff./bdeReference.java
---------